Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloudpickle dependency #975

Merged
merged 10 commits into from
Nov 29, 2023
Merged

Update cloudpickle dependency #975

merged 10 commits into from
Nov 29, 2023

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Jul 26, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-903063, SNOW-898480

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Upper-bound cloudpickle version in setup.py to include version ==2.2.1 for python runtime <3.11. We don't include cloudpickle versions 2.1.0 and 2.2.0 because they are not available on server.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 26, 2023
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner July 26, 2023 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
@sfc-gh-aalam sfc-gh-aalam reopened this Jul 31, 2023
@sfc-gh-yixie
Copy link
Collaborator

Is the test failure because of cloudpickle 2.2.1?

@sfc-gh-aalam
Copy link
Contributor Author

Is the test failure because of cloudpickle 2.2.1?

Yes. I'll re-run these tests once the we release the patched version of snowpark on the server

@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) November 29, 2023 23:00
sfc-gh-mkeller
sfc-gh-mkeller approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-aalam sfc-gh-aalam merged commit 7a5a4bf into main Nov 29, 2023
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-update-cloudpickle-dependency branch November 29, 2023 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-hpu sfc-gh-hpu Awaiting requested review from sfc-gh-hpu sfc-gh-hpu was automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-aalam @sfc-gh-yixie @sfc-gh-mkeller @sfc-gh-sfan