Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spectrum loading for other input types #195

Closed
4 tasks done
douweschulte opened this issue Oct 7, 2022 · 3 comments
Closed
4 tasks done

Implement spectrum loading for other input types #195

douweschulte opened this issue Oct 7, 2022 · 3 comments
Labels
A-batchfile Area: Related to batchfiles used to set up runs

Comments

@douweschulte
Copy link
Member

douweschulte commented Oct 7, 2022

Now the spectrum loading only works with Peaks data. To implement this for other data (or now only Novor) there is a need to specify the raw data files differently. With each input file that has raw data (scan numbers) (so peaks and Novor) there should be the option to specify the file (with Novor) or directory (with peaks) where the raw data can be found. For this the global RawDataDirectory will have to be deprecated and moved to the separate input definitions instead. For now the global one can be used as a fallback for the local one to make sure any batchfiles defined for 1.2.0 will continue to work, even though a deprecated warning will be shown.

Possible programs to support:

  • Peaks
  • MaxNovo
  • Casanovo
  • Novor
@douweschulte douweschulte added the A-batchfile Area: Related to batchfiles used to set up runs label Oct 7, 2022
@douweschulte
Copy link
Member Author

To support other types of input data take a look at HLXLToolChain in BMS-developers.

@douweschulte
Copy link
Member Author

There is one major problem with mgf though. It does not store the fragmentation method, so it will be hard to provide accurate annotations from these files.

@douweschulte
Copy link
Member Author

There is a minor problem with Novor, the scans that are retrieved (only when using mgf file input) do not seem to match the sequences, very likely the scan numbers have some layer of indirection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-batchfile Area: Related to batchfiles used to set up runs
Projects
None yet
Development

No branches or pull requests

1 participant