Add document validation and fix their HTTP binding #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Jun 24, 2020
JordonPhillips
approved these changes
Jun 24, 2020
mtdowling
force-pushed
the
fix-http-bindings
branch
from
49961e5 to
f86f1fd
Compare
kstich
reviewed
Jun 24, 2020
HTTP binding traits used invalid selectors that aren't actually supported, particularly around document types. Document types today can only be bound in the payload of an HTTP request. This change also add a flag to protocol trait definitions that defines if the protocol supports inline document types (along with built-in validation to detect when a protcool says it doesn't support document types but a service uses document types with the protocol). HTTP bindings previously stated that only "application/json" media types found in HTTP headers are base64 encoded, however any string with a mediaType needs to be base64 encoded.
mtdowling
force-pushed
the
fix-http-bindings
branch
from
f86f1fd to
a28f233
Compare
kstich
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP binding traits used invalid selectors that aren't actually
supported, particularly around document types. Document types today can
only be bound in the payload of an HTTP request. This change also add a
flag to protocol trait definitions that defines if the protocol supports
inline document types (along with built-in validation to detect when a
protcool says it doesn't support document types but a service uses
document types with the protocol). HTTP bindings previously stated that
only "application/json" media types found in HTTP headers are base64
encoded, however any string with a mediaType needs to be base64 encoded.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.