Add restJson1 protocol test for content-type and operation with no input #2322
Conversation
| output: TestNoPayloadInputOutput | ||
| } | ||
|
|
||
| apply TestNoInputNoPayload @httpRequestTests([ |
There was a problem hiding this comment.
There's already the RestJsonNoInputAndOutput test, to which we can add the forbidHeaders.
There was a problem hiding this comment.
Interestingly, that operation is POST, when it defines no input shape. That probably shouldn't build, or at least a warning should be emitted.
There was a problem hiding this comment.
IMO, it's better to add a new test here, as the goal of this test is to specifically verify that the content-type header doesn't get set.
There was a problem hiding this comment.
The key distinction between POST and GET is idempotency rather than the presence of a body. I'm pretty sure we have APIs today that are POST but bind their parameters to the URI/Headers. I'd agree with Hayden this is reasonable to add as a new test.
There was a problem hiding this comment.
I'm pretty sure we have APIs today that are POST but bind their parameters to the URI/Headers
Yeah that's fine because you're sending over data. But when the definition of the operation is such that no data could ever be sent, POST usage is probably a modeling mistake on behalf of the user.
| output: TestNoPayloadInputOutput | ||
| } | ||
|
|
||
| apply TestNoInputNoPayload @httpRequestTests([ |
There was a problem hiding this comment.
The key distinction between POST and GET is idempotency rather than the presence of a body. I'm pretty sure we have APIs today that are POST but bind their parameters to the URI/Headers. I'd agree with Hayden this is reasonable to add as a new test.
Background
Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.