Scalar RemovedShape events from ERROR -> NOTE #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Nov 10, 2023
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/RemovedShape.java
Outdated
Show resolved
Hide resolved
kstich
reviewed
Dec 13, 2023
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/RemovedShape.java
Outdated
Show resolved
Hide resolved
kstich
reviewed
Dec 13, 2023
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/RemovedShape.java
Outdated
Show resolved
Hide resolved
kstich
requested changes
Dec 13, 2023
rchache
force-pushed
the
RemovedShapeScalars
branch
from
6dd4e07 to
033026b
Compare
rchache
force-pushed
the
RemovedShapeScalars
branch
from
033026b to
965b13e
Compare
mtdowling
approved these changes
Jan 2, 2024
kstich
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
For scalar shapes (and non-enum strings), removing them is safe and therefore can be lowered from an ERROR to a NOTE
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.