Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add sha digest to resolved artifacts (#1961)" #1978

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

hpmellema
Copy link
Contributor

Description of changes:

This reverts commit facbdc3.

The sha-1 checksum is used within the maven resolver itself and I believe we should be able to re-use that sha rather than re-computing a checksum for each artifact.
The changes here are being reverted so that we can avoid adding unnecessary latency to the dependency resolution within the CLI.

The sha will be re-added using the resolver in: #1974

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hpmellema hpmellema requested a review from a team as a code owner September 14, 2023 13:45
@kstich kstich merged commit 0b15b27 into smithy-lang:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants