Map @httpPayload of list & map shapes to the document content type
#1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches behavior as documented on the [`@httpPayload` trait serialization rules](https://github.com/awslabs/smithy/blob/98dce46e0622eba4a294444228c171b9d9194885/docs/source-2.0/spec/http-bindings.rst#httppayload-trait:~:text=httpPrefixHeaders%2Dtrait%60.-,Serialization%20rules,-When%20a%20string).
Xtansia
added a commit
to Xtansia/opensearch-api-specification
that referenced
this pull request
Jun 30, 2023
The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
added a commit
to Xtansia/opensearch-api-specification
that referenced
this pull request
Jun 30, 2023
The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
added a commit
to Xtansia/opensearch-api-specification
that referenced
this pull request
Jun 30, 2023
The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com>
VachaShah
pushed a commit
to opensearch-project/opensearch-api-specification
that referenced
this pull request
Jul 11, 2023
) The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com>
mtdowling
approved these changes
Jul 13, 2023
aabeshov
pushed a commit
to aabeshov/opensearch-api-specification
that referenced
this pull request
Jul 16, 2023
…pensearch-project#127) The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alen Abeshov <a_abeshov@kbtu.kz>
aabeshov
pushed a commit
to aabeshov/opensearch-api-specification
that referenced
this pull request
Jul 16, 2023
…pensearch-project#127) The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alen Abeshov <a_abeshov@kbtu.kz>
aabeshov
pushed a commit
to aabeshov/opensearch-api-specification
that referenced
this pull request
Jul 16, 2023
…pensearch-project#127) The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com>
aabeshov
pushed a commit
to aabeshov/opensearch-api-specification
that referenced
this pull request
Jul 16, 2023
…pensearch-project#127) The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alen Abeshov <a_abeshov@kbtu.kz>
aabeshov
pushed a commit
to aabeshov/opensearch-api-specification
that referenced
this pull request
Jul 16, 2023
…pensearch-project#127) The aws.protocols#restJson1 protocol explicitly disallows lists and maps for @httpPayload. Requires workaround due to AbstractRestProtocol being package-private, and a bug in HttpBindingIndex waiting on PR smithy-lang/smithy#1840 Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Matches behavior as documented on the
@httpPayloadtrait serialization rules.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.