Update supported httpChecksum algorithms

smithy-lang · Aug 28, 2024 · c74f14e · c74f14e
1 parent 8b21de7
commit c74f14e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTrait.java b/smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTrait.java
@@ -38,7 +38,8 @@
 public final class HttpChecksumTrait extends AbstractTrait implements ToSmithyBuilder<HttpChecksumTrait> {
     public static final ShapeId ID = ShapeId.from("aws.protocols#httpChecksum");
     public static final String CHECKSUM_PREFIX = "x-amz-checksum-";
-    public static final List<String> CHECKSUM_ALGORITHMS = ListUtils.of("CRC32C", "CRC32", "SHA1", "SHA256");
+    public static final List<String> CHECKSUM_ALGORITHMS = ListUtils.of("CRC64NVME", "CRC32C", "CRC32",
+            "SHA1", "SHA256");
     public static final List<String> VALIDATION_MODES = ListUtils.of("ENABLED");
 
     public static final String REQUEST_CHECKSUM_REQUIRED = "requestChecksumRequired";

diff --git a/smithy-aws-traits/src/test/java/software/amazon/smithy/aws/traits/HttpChecksumTraitTest.java b/smithy-aws-traits/src/test/java/software/amazon/smithy/aws/traits/HttpChecksumTraitTest.java
@@ -41,7 +41,7 @@ public class HttpChecksumTraitTest {
     public void loadsTrait() {
         TraitFactory provider = TraitFactory.createServiceFactory();
 
-        List<String> algorithms = new ArrayList<>(Arrays.asList("CRC32C", "CRC32", "SHA1", "SHA256"));
+        List<String> algorithms = new ArrayList<>(Arrays.asList("CRC64NVME", "CRC32C", "CRC32", "SHA1", "SHA256"));
         List<Node> responseAlgorithmNodes = new ArrayList<>();
         for (String algorithm: algorithms) {
             responseAlgorithmNodes.add(Node.from(algorithm));
@@ -62,7 +62,8 @@ public void loadsTrait() {
         assertThat(checksumTrait.isRequestChecksumRequired(), is(true));
         assertThat(checksumTrait.getRequestAlgorithmMember().get(), equalTo("ChecksumAlgorithm"));
         assertThat(checksumTrait.getRequestValidationModeMember().get(), equalTo("ChecksumMode"));
-        assertThat(checksumTrait.getResponseAlgorithms(), containsInRelativeOrder("CRC32C", "CRC32", "SHA1", "SHA256"));
+        assertThat(checksumTrait.getResponseAlgorithms(), containsInRelativeOrder("CRC64NVME", "CRC32C", "CRC32",
+                "SHA1", "SHA256"));
 
         assertThat(node.expectBooleanMember("requestChecksumRequired"), equalTo(BooleanNode.from(true)));
         assertThat(node.expectStringMember("requestAlgorithmMember"), equalTo(Node.from("ChecksumAlgorithm")));