Remove unnecessary src folder prepend in useShapeWriter #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SymbolProvider(SymbolVisitor) also includes the src folder, so this is unnecessary.
trivikr
approved these changes
May 26, 2022
mtdowling
approved these changes
May 26, 2022
This was referenced May 27, 2022
Merged
gosar
added a commit
to gosar/smithy-typescript
that referenced
this pull request
Jun 2, 2022
gosar
added a commit
to gosar/smithy-typescript
that referenced
this pull request
Jun 7, 2022
gosar
added a commit
to gosar/smithy-typescript
that referenced
this pull request
Jun 18, 2022
gosar
added a commit
to gosar/smithy-typescript
that referenced
this pull request
Jul 1, 2022
gosar
added a commit
to gosar/smithy-typescript
that referenced
this pull request
Jul 1, 2022
gosar
added a commit
that referenced
this pull request
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SymbolProvider(SymbolVisitor) also includes the src folder, so this is
unnecessary. Conceptually it also makes sense that the filename is responsibility of the Symbol Provider, not the Delegator.
Ran
yarn generate-clients && yarn test:protocols && yarn generate-clients -s && yarn test:server-protocolslocally with and there is no change to generated clients.This is in preparation to use WriterDelegator (as part of DirectedCodegen) so that WriterDelegator.useShapeWriter can be used directly without needing to override in TypeScriptDelegator.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.