Remove the public HTTP dependency from aws-sigv4 #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Aug 15, 2023
Velfi
reviewed
Aug 15, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Removes the public http dependency from the aws-sigv4 crate to avoid compatibility issues with http = 1.0 and to support the http refactor
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Aug 15, 2023
| } | ||
|
|
||
| #[test] | ||
| fn test_trim_all_does_nothing_when_there_are_no_spaces(s in "[^ ]*") { | ||
| assert_eq!(trim_all(s.as_bytes()).as_ref(), s.as_bytes()); | ||
| } | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_normalize_header_value_returns_expected_error_on_invalid_utf8() { |
There was a problem hiding this comment.
Isn't this test still relevant?
There was a problem hiding this comment.
no, invalid UTF-8 headers can't make it in as input anymore
There was a problem hiding this comment.
Ah, got it. Makes sense.
jdisanti
approved these changes
Aug 15, 2023
ysaito1001
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Removes the public http dependency from the aws-sigv4 crate to avoid compatibility issues with http = 1.0 and to support the http refactor
Description
SignableRequest::newto remove the direct exposure of HTTP typesTesting
IT/UT
Checklist
TODO: changelog
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.