Skip to content

Commit

Permalink
fix up a few more failing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rcoh committed Mar 14, 2023
1 parent e96790b commit f59ad8d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -759,9 +759,6 @@ class ServerProtocolTestGenerator(
private const val RestJsonValidation = "aws.protocoltests.restjson.validation#RestJsonValidation"
private const val MalformedRangeValidation = "aws.protocoltests.extras.restjson.validation#MalformedRangeValidation"
private val ExpectFail: Set<FailingTest> = setOf(
// Pending merge from the Smithy team: see https://github.com/awslabs/smithy/pull/1477.
FailingTest(RestJson, "RestJsonWithPayloadExpectsImpliedContentType", TestType.MalformedRequest),

// Pending resolution from the Smithy team, see https://github.com/awslabs/smithy/issues/1068.
FailingTest(RestJson, "RestJsonHttpWithHeadersButNoPayload", TestType.Request),

Expand Down Expand Up @@ -838,6 +835,8 @@ class ServerProtocolTestGenerator(
"queryTimestamp": 1,
"queryTimestampList": [1, 2, 3],
"queryEnum": "Foo",
"queryIntegerEnum": 1,
"queryIntegerEnumList": [1,2,3],
"queryEnumList": ["Foo", "Baz", "Bar"],
"queryParamsMapOfStringList": {
"String": ["Hello there"],
Expand Down Expand Up @@ -915,7 +914,7 @@ class ServerProtocolTestGenerator(
// TODO(https://github.com/awslabs/smithy-rs/issues/1288): Contribute a PR to fix them upstream.
private val BrokenRequestTests = mapOf(
// TODO(https://github.com/awslabs/smithy/pull/1564)
Pair(RestJson, "RestJsonAllQueryStringTypes") to ::fixRestJsonAllQueryStringTypes,
// Pair(RestJson, "RestJsonAllQueryStringTypes") to ::fixRestJsonAllQueryStringTypes,
// TODO(https://github.com/awslabs/smithy/pull/1562)
Pair(RestJson, "RestJsonQueryStringEscaping") to ::fixRestJsonQueryStringEscaping,
)
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ kotlin.code.style=official

# codegen
smithyGradlePluginVersion=0.6.0
smithyVersion=1.27.1
smithyVersion=1.27.2

# kotlin
kotlinVersion=1.7.21
Expand Down

0 comments on commit f59ad8d

Please sign in to comment.