Rename ApiException and ModeledApiException and add error #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
rename-exceptions
branch
from
42a1315 to
b948ab8
Compare
ApiException is renamed to CallException to better indicate that the error may not have actually hit a service or be related to the API (e.g., it could be a timeout, networking error, protocol error, etc.) ModeledApiException is renamed to ModeledException since it no longer extends from ApiException and Api isn't helping make the name more clear. Exceptions have been moved to a top-level error package, since not all errors are modeled or have a schema, and to better group them.
mtdowling
force-pushed
the
rename-exceptions
branch
from
b948ab8 to
9b9dae4
Compare
mtdowling
changed the title
hpmellema
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename ApiException and ModeledApiException and move
ApiException is renamed to CallException to better indicate that the error may not have actually hit a service or be related to the API (e.g., it could be a timeout, networking error, protocol error, etc.)
ModeledApiException is renamed to ModeledException since it no longer extends from ApiException and Api isn't helping make the name more clear.
Exceptions have been moved to a top-level error package, since not all errors are modeled or have a schema, and to better group them.