-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlashLFQ refactoring to enable generic peak operations #837
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
==========================================
- Coverage 77.78% 77.77% -0.02%
==========================================
Files 230 231 +1
Lines 34152 34170 +18
Branches 3538 3540 +2
==========================================
+ Hits 26566 26576 +10
- Misses 6983 6990 +7
- Partials 603 604 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if these interfaces should be in projects above FlashLFQ so that packages that FlashLFQ uses could implement these interfaces for use in FlashLFQ functions
/// The position of the datum in the separation domain, | ||
/// e.g., retention time, ion mobility | ||
/// </summary> | ||
public double RelativeSeparationValue { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use retention time here instead?
Added an interface, ISingleScanDatum and and abstract class, TraceablePeak, to enable the generic use of pre-existing FlashLFQ functions.
ISingleScanDatum
TraceablePeak