-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydroxy proline diagnostic ion error #2324
Merged
trishorts
merged 15 commits into
smith-chem-wisc:master
from
trishorts:hydroxyProlineDiagnosticIonError
Dec 12, 2023
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1aeb4a8
reverted filtering method for psms passed to FlashLFQ
Alexander-Sol 1312c5d
Merge branch 'Alexander-Sol-FilteringHotfix'
1230534
Merge remote-tracking branch 'upstream/master'
58a2e8a
Merge remote-tracking branch 'upstream/master'
9339535
Merge remote-tracking branch 'upstream/master'
trishorts c967b61
Merge branch 'master' of https://github.com/trishorts/MetaMorpheus
trishorts c624070
Merge remote-tracking branch 'upstream/master'
trishorts 3682d10
Merge remote-tracking branch 'upstream/master'
trishorts 32763af
Merge remote-tracking branch 'upstream/master'
trishorts bd18b72
Merge remote-tracking branch 'upstream/master'
trishorts b6b921f
Merge remote-tracking branch 'upstream/master'
trishorts 057436e
update diagnostic ion mass for hydroxyproline
trishorts 5a5db86
Merge branch 'master' into hydroxyProlineDiagnosticIonError
trishorts 6b5600f
wrong mass of course
trishorts 33f84fd
Merge branch 'hydroxyProlineDiagnosticIonError' of https://github.com…
trishorts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the comment, you said that the mass was updated to 176.0764. not 170.07642.
In the blog post, Ben Orsburn said that he pulled an XIC for 176.076, but then he shows a spectra where an ion at 171.0766 is highlighted.
Are the diagnostic ions recorded as masses and then converted to mz downstream? I'm a little confused as to what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong mass in comment. also correct now. forgot to push yesterday before i left. these are mzs so no conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.