-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute spectrum similarity in meta draw #2299
Compute spectrum similarity in meta draw #2299
Conversation
…milarityInMetaDraw
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2299 +/- ##
==========================================
+ Coverage 92.28% 92.33% +0.05%
==========================================
Files 135 135
Lines 20616 20665 +49
Branches 2836 2842 +6
==========================================
+ Hits 19025 19081 +56
+ Misses 1106 1099 -7
Partials 485 485
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you ran this? Is the spectrum similarity displayed automatically?
In my PR, you have to go in to settings and check Spectral Similarity before it's calculated/displayed. It's really unintuitive. Hopefully this PR can make it more obvious
If the spectral similarity in the .psmtsv file is different than the calculated similarity, how is that handled?
Yes
Yes. I changed the default for diplay similarity to true.
Both are added to the legend (original similarity and new similarity) or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. One question and one suggestion
MetaMorpheus/GuiFunctions/MetaDraw/SpectrumMatch/SpectrumMatchPlot.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feature
Need test coverage. Need to edit CodeCov to show test coverage of GUI Functions project |
…com/trishorts/MetaMorpheus into computeSpectrumSimilarityInMetaDraw
I think we're good on codecov now. The critical function in LibrarySpectrum is now tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions before approval
MetaDraw reports the original spectrum similarity found in the search, even when displaying the scan against a new library spectrum. This PR enables MetaDraw to compute spectrum similarity on the fly against the displayed library spectrum.
The key parts of this code were generated by Alex.