Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glyco write individual file results #2252

Merged

Conversation

trishorts
Copy link
Contributor

@trishorts trishorts commented Feb 16, 2023

Last step before I add label free quant to the glyco search task. This PR just splits the results into individual file folders for those users that want such a thing. It is similar to the individual file folder results of search task.

@trishorts trishorts added Output Enhancement New Feature WIP Work in progress, not ready for review labels Feb 16, 2023
@trishorts trishorts changed the title Glyco write individual file results [WIP] Glyco write individual file results Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #2252 (67e6144) into master (a27026f) will increase coverage by 0.37%.
The diff coverage is 95.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2252      +/-   ##
==========================================
+ Coverage   91.43%   91.80%   +0.37%     
==========================================
  Files         134      134              
  Lines       20153    20185      +32     
  Branches     2807     2815       +8     
==========================================
+ Hits        18427    18531     +104     
+ Misses       1237     1173      -64     
+ Partials      489      481       -8     
Impacted Files Coverage Δ
...gineLayer/ClassicSearch/MiniClassicSearchEngine.cs 92.14% <ø> (ø)
...TaskLayer/GlycoSearchTask/GlycoSearchParameters.cs 100.00% <ø> (ø)
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 92.50% <ø> (ø)
...yer/GlycoSearchTask/PostGlycoSearchAnalysisTask.cs 92.76% <95.91%> (+12.76%) ⬆️
...TaskLayer/GlycoSearchTask/GlycoProteinParsimony.cs 76.36% <100.00%> (ø)

... and 4 files with indirect coverage changes

@trishorts trishorts removed the WIP Work in progress, not ready for review label Mar 24, 2023
@trishorts trishorts changed the title [WIP] Glyco write individual file results Glyco write individual file results Mar 27, 2023
@acesnik
Copy link
Contributor

acesnik commented Mar 27, 2023

The code changes look good. I haven't tested the GUI or functionality.

@trishorts trishorts merged commit 11592ab into smith-chem-wisc:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants