Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Modernize display-text component #617

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Modernize display-text component #617

merged 2 commits into from
Jun 23, 2020

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Jun 23, 2020 •
edited
Loading

💣 Breaking

We rename here tagName -> htmlTag (as a match for polaris-react's element property), because using tagName with angle-bracket syntax seems to result in adding an extra wrapper with tagName around the component.

@vladucu vladucu self-assigned this Jun 23, 2020
@vladucu vladucu requested a review from andrewpye June 23, 2020 08:03
andrewpye
andrewpye approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vladucu vladucu merged commit ebd1ba4 into refactor/es6-classes Jun 23, 2020
@vladucu vladucu deleted the refactor/es6-display-text branch June 23, 2020 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewpye andrewpye andrewpye approved these changes

Assignees

@vladucu vladucu

Labels
breaking internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladucu @andrewpye