This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Remove event object from button mouse action handler invocations #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vladucu added 👍 |
vladucu
approved these changes
Apr 8, 2019
delete-merged-branch
bot
deleted the
fix/remove-event-param-from-button-mouse-action-handlers
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#291 inadvertently changed the interface for
polaris-button, such that the mouse event object was passed to theonClick,onFocusandonBluractions on invocation, which it never was before my refactor. This change removes the erroneous event object, fixing the signature foronClick,onFocusandonBlur👍