This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Update polaris-spinner to v3.10.0 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomnez
force-pushed
the
update/spinner-v3.10.0
branch
from
0d1f710 to
26a3a9e
Compare
andrewpye
approved these changes
Apr 2, 2019
| }} | ||
| aria-label={{accessibilityLabel}} | ||
| data-test-polaris-spinner | ||
| > |
There was a problem hiding this comment.
Does this change mean we can remove the SvgHandling mixin from polaris-spinner?
| 'Integration | Component | polaris spinner', | ||
| { | ||
| integration: true, | ||
| module('Integration | Component | polaris spinner', function(hooks) { |
vladucu
reviewed
Apr 2, 2019
addon/components/polaris-spinner.js
Outdated
| return `polaris/spinner-${this.get('normalizedSize')}`; | ||
| spinnerSVG: computed('normalizedSize', function() { | ||
| let size = this.get('normalizedSize') === 'large' ? 'large' : 'small'; | ||
| return `/@smile-io/ember-polaris/illustrations/spinner-${size}.svg`; |
There was a problem hiding this comment.
let's make a map with explicit image sizes, ex
const spinnerSVGSources = {
small: '/@smile-io/ember-polaris/illustrations/spinner-small.svg'
large: /@smile-io/ember-polaris/illustrations/spinner-large.svg
}This is to avoid issues with fingerprinting
| }} | ||
| aria-label={{accessibilityLabel}} | ||
| data-test-polaris-spinner | ||
| > |
vladucu
approved these changes
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.