-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
the diff gives me a bunch of changes....are those just shifting things around? nothing really changed in functionality? |
From what I could tell, the vast majority of the diff comes from a) moving things around b) adding i18n stuff, which works out with the same result as what we've already got here. |
@vladucu but if you think there's something I've missed, let me know! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewpye do you mind re-checking the diff again here to make sure you've been looking at the right one previously
@vladucu yep got the right one. Made a couple of tweaks, wondering if there's anything else you think I've missed? |
@vladucu bump 😅 |
ops, sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,50 @@ | |||
export function measureColumn(tableData) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
figured it's something along those lines 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Adds the new
data-polaris-header-cell
attribute topolaris-data-table
cells withheader=true
.