Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Update data table to Polaris v3.10.0 #297

Merged
merged 9 commits into from
Apr 5, 2019

Conversation

andrewpye
Copy link
Member

Adds the new data-polaris-header-cell attribute to polaris-data-table cells with header=true.

@andrewpye andrewpye self-assigned this Mar 26, 2019
@andrewpye andrewpye requested review from vladucu and tomnez March 26, 2019 11:34
@andrewpye
Copy link
Member Author

@vladucu
Copy link
Member

vladucu commented Mar 26, 2019

the diff gives me a bunch of changes....are those just shifting things around? nothing really changed in functionality?

@andrewpye
Copy link
Member Author

the diff gives me a bunch of changes....are those just shifting things around? nothing really changed in functionality?

From what I could tell, the vast majority of the diff comes from a) moving things around b) adding i18n stuff, which works out with the same result as what we've already got here.

@andrewpye
Copy link
Member Author

@vladucu but if you think there's something I've missed, let me know! 🙏

Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewpye do you mind re-checking the diff again here to make sure you've been looking at the right one previously

@andrewpye
Copy link
Member Author

@vladucu yep got the right one. Made a couple of tweaks, wondering if there's anything else you think I've missed?

@andrewpye andrewpye requested a review from vladucu March 29, 2019 16:01
@andrewpye
Copy link
Member Author

@vladucu bump 😅

@vladucu
Copy link
Member

vladucu commented Apr 3, 2019

ops, sorry
on it in 10 mins

Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything we need to update related to the changes below
Screen Shot 2019-04-04 at 8 56 20 PM
?

@@ -0,0 +1,50 @@
export function measureColumn(tableData) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some slight difference to the original here
Screen Shot 2019-04-04 at 9 01 27 PM

@andrewpye
Copy link
Member Author

Is there anything we need to update related to the changes below
Screen Shot 2019-04-04 at 8 56 20 PM
?

The sortDirection = defaultSortDirection change doesn't seem to be important since they reassign sortDirection before it gets used 🤷‍♂️Adding it anyway though in case a future change in this area needs it and we miss it.

sorted doesn't seem to be used at all, so I'm just going to remove it #yolo 😅

@andrewpye andrewpye requested a review from vladucu April 5, 2019 10:46
@vladucu
Copy link
Member

vladucu commented Apr 5, 2019

The sortDirection = defaultSortDirection change doesn't seem to be important since they reassign sortDirection before it gets used 🤷‍♂️Adding it anyway though in case a future change in this area needs it and we miss it.
sorted doesn't seem to be used at all, so I'm just going to remove it #yolo 😅

figured it's something along those lines 👍

Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@andrewpye andrewpye merged commit 3aebc78 into update/polaris-v3.10.0 Apr 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the update/data-table-v3.10.0 branch April 5, 2019 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants