This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Add support for disabled and loading states to polaris-setting-toggle #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakumar-kailasam
suggested changes
Oct 10, 2018
docs/setting-toggle.md
Outdated
| @@ -14,6 +14,7 @@ Inline usage: | |||
| enabled=enabled | |||
| action=(hash | |||
| text="Toggle it!" | |||
| loading=isToggleSettingRunning | |||
There was a problem hiding this comment.
should we document disabled too?
There was a problem hiding this comment.
Thought about it but I'm not sure there's any real value
| `); | ||
|
|
||
| let button = find(settingActionButtonSelector); | ||
| assert.ok( |
There was a problem hiding this comment.
this could also be written as
assert.dom(settingActionButtonSelector).hasClass('Polaris-Button--loading', 'button is in loading state when loading is true');There was a problem hiding this comment.
It could... but I want to get this out quickly so wasn't going to update the test file to use the newer things 🤷♂️
sivakumar-kailasam
approved these changes
Oct 10, 2018
vladucu
approved these changes
Oct 10, 2018
delete-merged-branch
bot
deleted the
enhancement/setting-toggle-disabled-and-loading-states
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found that the
disabledandloadingoptions inpolaris-setting-toggle'sactionhash weren't supported, so added them in.