This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Layout's annotated section to use a new css selector instead of subdued text style for description #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpye
suggested changes
Oct 8, 2018
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| - [#168](https://github.com/smile-io/ember-polaris/pull/168) [INTERNAL] Upgrade to Ember CLI `3.4.2` | |||
| - [#171](https://github.com/smile-io/ember-polaris/pull/171) [UPDATE] Shopify Polaris `v2.11.0` | |||
| - [#174](https://github.com/smile-io/ember-polaris/pull/174) [FEATURE] Add `polaris-inline-error` component | |||
| - [#191](https://github.com/smile-io/ember-polaris/pull/191) [ENHANCEMENT] Layout's annotated section to use a new css selector instead of subdued text style for description | |||
There was a problem hiding this comment.
Nit: this description is pretty complex for those just wanting to have an overview of what's happened. How about something like Update polaris-layout/annotated-section styling to match Polaris v2.11.0 instead?
| @@ -22,6 +22,13 @@ const layoutAnnotationWrapperSelector = buildNestedSelector( | |||
| 'div.Polaris-Layout__AnnotationWrapper' | |||
| ); | |||
|
|
|||
| const annotationSectionDescriptionSelector = (containerSelector) => | |||
There was a problem hiding this comment.
Nit: the name annotationSectionDescriptionSelector makes this sound like an actual selector, rather than a function that generates a selector.
There was a problem hiding this comment.
Would converting this file/component to use the new test selectors help here?
There was a problem hiding this comment.
ah yes, didn't realize we had that here already 🙂
andrewpye
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
I reckon this looks good now, thanks @sivakumar-kailasam! 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wide screen
** Small screen **
Fixes #190