Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Depedencies and tweaks #140

Merged
merged 7 commits into from
Jun 25, 2018
Merged

Depedencies and tweaks #140

merged 7 commits into from
Jun 25, 2018

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Jun 21, 2018 •
edited
Loading

Needs some testing in apps, tests pass locally but not on Travis...will check

@vladucu vladucu self-assigned this Jun 21, 2018
andrewpye
andrewpye approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, obviously test this carefully with some host apps before shipping it.

Looks like there was maybe a network error or something on the Travis run 🤔

@vladucu vladucu merged commit 4503d1c into master Jun 25, 2018
@vladucu vladucu deleted the depedencies-and-tweaks branch July 9, 2018 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewpye andrewpye andrewpye approved these changes

Assignees

@vladucu vladucu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladucu @andrewpye