This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Fix focused button group item z-index #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomnez
approved these changes
May 11, 2018
andrewpye
added a commit
that referenced
this pull request
May 14, 2018
* Add focused class to focused button group items * Add note to docs about needing to explicitly wrap button group items in segmented button groups * Fix dummy app index
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120:
Found that the reason I couldn't get this working yesterday was that when the code doesn't explicitly add the item wrapper component around each button in the group, we can't handle the focus/blur events on the auto-added wrapper
divs. Once the user explicitly adds the item wrapper component around each button, this works fine; I've added a note to the documentation about this.I guess we could also hack something together on the auto-wrapper system to handle focus/blur on the wrapper
divs, but that'd be pretty dirty and probs not worth doing...