Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Fix day button not being disabled when disabled is true #115

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Fix day button not being disabled when disabled is true #115

merged 2 commits into from
Apr 17, 2018

Conversation

tomnez
Copy link
Contributor

@tomnez tomnez commented Apr 13, 2018

Forgot to add disabled attribute to the buttons in the day template, so disabled dates were appearing disabled but were still clickable 😳

@tomnez tomnez requested review from andrewpye and vladucu April 13, 2018 17:23
@tomnez tomnez self-assigned this Apr 13, 2018
andrewpye
andrewpye approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible fix 😛 Maybe worth adding a test for this?

@tomnez
Copy link
Contributor Author

tomnez commented Apr 17, 2018

@andrewpye test added!

@tomnez tomnez merged commit 3914329 into master Apr 17, 2018
@tomnez tomnez deleted the date-picker-add-disabled-attr-to-day branch April 18, 2018 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vladucu vladucu vladucu approved these changes

@andrewpye andrewpye andrewpye approved these changes

Assignees

@tomnez tomnez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomnez @vladucu @andrewpye