Allow updated psr log #3099
Merged
Allow updated psr log #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option to let it downgrade psr/log
|
I'm in favor of removing PHP 7.2 support @t0mmy742 Also thank you for this contribution. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlimPHP is easily compatible with
psr/log^2.0and^3.0.String cast has be added to
\Slim\Loggerclass since\error_logfunction takes a string as parameter.To complete: Should we remove PHP 7.2 support ? Some dependencies of composer.json could not be updated to their higher version since most of them remove PHP 7.2 support. This PHPversion is EOL for 8 months (30 Nov 2020).
If needed, I can make another PR for this.
Closes #3096
Closes #3097
Closes #3098