Don't use libxml_disable_entity_loader when deprecated #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports the important bit of slimphp/Slim-Http@4715329 You're on your own for full test suite to maintain PHP 5.5 compatibility, but this is the only thing I've run into where PHP 8 is a problem.
Ayesh
added a commit
to Ayesh/Slim
that referenced
this pull request
Sep 27, 2021
This function is [deprecated in PHP 8.0](https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation). Since this fork depends on PHP > 8.0, it is safe to remove all calls to this function. Related: slimphp#3092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the important bit of slimphp/Slim-Http@4715329
You're on your own for full test suite to maintain PHP 5.5 compatibility, but this is the only thing I've run into where PHP 8 is a problem.