Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose async-trait to as a feature which can be enabled or disabled selectively #313

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Jan 6, 2025

Resolves #309

This is really a no-op change except assuring that all of the test coverage runs for both async-trait and no-async-trait usages.

@slawlor slawlor force-pushed the feat_309_async_cluster branch 2 times, most recently from b97b926 to 8d1794d Compare January 6, 2025 15:54
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.04%. Comparing base (f14e712) to head (70d06f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   82.19%   82.04%   -0.15%     
==========================================
  Files          61       61              
  Lines       11124    12182    +1058     
==========================================
+ Hits         9143     9995     +852     
- Misses       1981     2187     +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slawlor slawlor force-pushed the feat_309_async_cluster branch 4 times, most recently from bccdedd to db8c9e2 Compare January 6, 2025 16:31
@slawlor slawlor marked this pull request as ready for review January 6, 2025 16:37
@slawlor slawlor force-pushed the feat_309_async_cluster branch from db8c9e2 to 70d06f8 Compare January 6, 2025 16:39
@slawlor slawlor merged commit 1ae5d86 into main Jan 6, 2025
14 checks passed
@slawlor slawlor deleted the feat_309_async_cluster branch January 6, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to opt-out async-trait feature when using ractor_cluster
1 participant