Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing callsites for a bunch of factory stats #273

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Missing callsites for a bunch of factory stats #273

merged 1 commit into from
Oct 11, 2024

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Oct 11, 2024

Some stat collection was lost in merging various branches. This fixes a fix on another branch that was an oversight and should have been collected stats (right now they'll report 0).

@slawlor slawlor marked this pull request as ready for review October 11, 2024 00:25
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (1be1812) to head (dfd5078).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ractor/src/factory/worker.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   80.43%   80.60%   +0.16%     
==========================================
  Files          60       60              
  Lines       10388    10405      +17     
==========================================
+ Hits         8356     8387      +31     
+ Misses       2032     2018      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slawlor slawlor merged commit 9a9a938 into main Oct 11, 2024
13 checks passed
@slawlor slawlor deleted the stats_fix branch October 11, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant