Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More memory improvements, but smaller. No API changes #261

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Sep 22, 2024

This change further reduces the memory utilization of the actors, down to ~ 13KB. However it also has the added benefit that some benchmarks are showing additional wins in message processing latencies.

Benchmarking Waiting on 100 actors to process first message: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.5s, enable flat sampling, or reduce sample count to 60.
Waiting on 100 actors to process first message
                        time:   [804.50 µs 818.01 µs 833.69 µs]
                        change: [-34.074% -26.977% -21.803%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe

Waiting on 1000 actors to process first message
                        time:   [9.6242 ms 9.7702 ms 9.9224 ms]
                        change: [-8.5173% -5.9246% -3.3614%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild

Waiting on 100000 messages to be processed
                        time:   [17.640 ms 17.759 ms 17.881 ms]
                        change: [-3.1347% -2.0925% -1.0043%] (p = 0.00 < 0.05)
                        Performance has improved.

No change to other metrics.

This change further reduces the memory utilization of the actors, down to ~ 13KB. However it also has the added benefit that some benchmarks are showing additional wins in message processing latencies.

```
Benchmarking Waiting on 100 actors to process first message: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.5s, enable flat sampling, or reduce sample count to 60.
Waiting on 100 actors to process first message
                        time:   [804.50 µs 818.01 µs 833.69 µs]
                        change: [-34.074% -26.977% -21.803%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe

Waiting on 1000 actors to process first message
                        time:   [9.6242 ms 9.7702 ms 9.9224 ms]
                        change: [-8.5173% -5.9246% -3.3614%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild

Waiting on 100000 messages to be processed
                        time:   [17.640 ms 17.759 ms 17.881 ms]
                        change: [-3.1347% -2.0925% -1.0043%] (p = 0.00 < 0.05)
                        Performance has improved.

```

No change to other metrics.
@slawlor slawlor force-pushed the memory_optimization branch from 7a694a4 to 70bcbc1 Compare September 22, 2024 01:01
@slawlor slawlor mentioned this pull request Sep 22, 2024
@slawlor slawlor marked this pull request as ready for review September 22, 2024 01:12
@slawlor slawlor merged commit d40b429 into main Sep 22, 2024
12 checks passed
@slawlor slawlor deleted the memory_optimization branch September 22, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant