We should only notify the stop listener AFTER post_stop has execute…

…d, which is when the state gets set to `Stopped` Closes Add a pre_stop fn or some way to wait until post_stop has finished #254
slawlor · Sep 13, 2024 · 5a97b73 · 5a97b73
1 parent 67d657e
commit 5a97b73
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/ractor/Cargo.toml b/ractor/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "ractor"
-version = "0.10.3"
+version = "0.10.4"
 authors = ["Sean Lawlor", "Evan Au", "Dillon George"]
 description = "A actor framework for Rust"
 documentation = "https://docs.rs/ractor"
@@ -19,7 +19,6 @@ cluster = []
 tokio_runtime = ["tokio/time", "tokio/rt", "tokio/macros", "tokio/tracing"]
 blanket_serde = ["serde", "pot", "cluster"]
 
-# default = ["async-std"]
 default = ["tokio_runtime", "async-trait"]
 
 [dependencies]

diff --git a/ractor/src/actor/actor_cell.rs b/ractor/src/actor/actor_cell.rs
@@ -323,7 +323,11 @@ impl ActorCell {
             // Leave all + stop monitoring pg groups (if any)
             crate::pg::demonitor_all(self.get_id());
             crate::pg::leave_all(self.get_id());
+        }
 
+        // Fix for #254. We should only notify the stop listener AFTER post_stop
+        // has executed, which is when the state gets set to `Stopped`.
+        if status == ActorStatus::Stopped {
             // notify whoever might be waiting on the stop signal
             self.inner.notify_stop_listener();
         }

diff --git a/ractor_cluster/Cargo.toml b/ractor_cluster/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "ractor_cluster"
-version = "0.10.3"
+version = "0.10.4"
 authors = ["Sean Lawlor", "Evan Au", "Dillon George"]
 description = "Distributed cluster environment of Ractor actors"
 documentation = "https://docs.rs/ractor"

diff --git a/ractor_cluster_derive/Cargo.toml b/ractor_cluster_derive/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "ractor_cluster_derive"
-version = "0.10.3"
+version = "0.10.4"
 authors = ["Sean Lawlor <seanlawlor@fb.com>"]
 description = "Derives for ractor_cluster"
 license = "MIT"