-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy import modules to reduce importing time #4802
base: master
Are you sure you want to change the base?
Conversation
Method to verify the import time:
Result of this change:
![]()
![]()
![]()
![]() |
Hi @Michaelvll, could you please help trigger smoke_test for this PR? Thanks! BTW, as I have described in the PR description, this PR only covers the 3rd party modules and the import time is still long and needs to be reduced further. |
/quicktest-core |
Thanks for submitting this PR @DanielZhangQD! Doing the core part inanother PR sounds good to me. I have some quick questions:
|
Hi @Michaelvll, thanks for the info!
For 2.1, I see And I will fix the issue with quicktest-core. |
Part of #4678
This PR only covers the third-party modules to import lazily, however, from the test result below, it still takes a long time to import the whole sky module.
So this needs to be improved further, e.g.:
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh