Change in the api call to fetch status using the commit ref instead o… #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f master Fixed issue sitture#63
|
Changes in the api call to fetch status using the commit ref instead of master |
| @@ -51,16 +51,21 @@ export default class AddProject extends React.Component { | |||
| }; | |||
| } | |||
| axios | |||
| .get( | |||
| .get( | |||
| `https://api.github.com/repos/${this.state.input}/commits/master/status`, | |||
There was a problem hiding this comment.
This is still making api calls using the master :ref instead of latest commit ref
There was a problem hiding this comment.
But then will user have to enter commit id as well as part of input
There was a problem hiding this comment.
This code is making call using master ref to fetch latest commit ref API URL from response and getting status from that only
There was a problem hiding this comment.
haroon-sheikh
requested changes
Oct 5, 2020
|
@sumitsawant Are you still looking into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f master
Fixes #63