Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with getting latest status of master #63

Open
2 tasks
haroon-sheikh opened this issue Oct 4, 2020 · 4 comments
Open
2 tasks

Fix an issue with getting latest status of master #63

haroon-sheikh opened this issue Oct 4, 2020 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@haroon-sheikh
Copy link
Collaborator

haroon-sheikh commented Oct 4, 2020 •
edited
Loading

We currently get the commit status by hitting this endpoint https://api.github.com/repos/cucumber/cucumber-jvm/commits/master/status

But REF master does not always return the status and errors in 404.

Tasks

Change the api call to fetch status using the commit ref instead of master

  • Get the latest commit ref from master
  • Use the latest commit ref to fetch the commit status

E.g.

https://api.github.com/repos/cucumber/cucumber-jvm/commits/master/status returns ❌
https://api.github.com/repos/cucumber/cucumber-jvm/commits/bb97c6943659018e5e8496aff6a18d73eec06f26/status 🆗
@haroon-sheikh haroon-sheikh added hacktoberfest bug Something isn't working good first issue Good for newcomers labels Oct 4, 2020
@sumitsawant
Copy link

I can give it a try @haroon-sheikh ! Will you assign me this one?

@haroon-sheikh
Copy link
Collaborator Author

@sumitsawant Go for it, let me know if you need a hand with anything.

@sumitsawant
Copy link

Sure @haroon-sheikh thanks a lot 😄 .Will let you know if I need any help !

sumitsawant added a commit to sumitsawant/commit-status that referenced this issue Oct 4, 2020
@sumitsawant
Change in the api call to fetch status using the commit ref instead o…
0c08c09 
…f master

Fixed issue sitture#63
@sumitsawant sumitsawant mentioned this issue Oct 4, 2020
Closed
@sumitsawant
Copy link

Hey @haroon-sheikh I have pushed the changes .Please review them and let me know if there are any changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change in the api call to fetch status using the commit ref instead o… sumitsawant/commit-status
2 participants
@haroon-sheikh @sumitsawant