Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of our recent webpack updates. This PR will likely require more discussion on the pros/cons of the proposed changes, as well as some refinement since we included a couple of potential paths forward which we'll need to decide between.
In summary, this PR provides a starting point for implementing proper code splitting of our JS assets, and a way to have WP enqueue the chunk files webpack creates. Currently, we rely on a single statically-named JS asset file per webpack entrypoint. This works fine, but it has some downsides:
contenthash
in the resulting filename).We may decide to discard this functionality as something provided out of the box by Groot, and instead document it as a potential update that can be added into themes which are based on Groot if/when needed.