Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to point to same case org #517

Closed
wants to merge 1 commit into from

Conversation

zbintliff
Copy link

Your actual org and remote has a lowercase s readme references uppercase S. Believe it or not this breaks dep tools like glide in edgecases. While fixing those tools are better I think we should import using the actual org and repo name.

Your actual org and remote has a lowercase `s` readme references uppercase `S`.  Believe it or not this breaks dep tools like `glide` in edgecases. While fixing those tools are better I think we should import using the actual org and repo name.
@harnash
Copy link

harnash commented Apr 12, 2017

This is also problem for code in github.com/sirupsen/logrus/hooks/syslog

@polds
Copy link
Contributor

polds commented Apr 12, 2017

Any chance we could get this merged? It's still leading to some confusion.

@harnash
Copy link

harnash commented Apr 13, 2017

This was reviewed sometime before and reverte. For more info go to #384

@zbintliff
Copy link
Author

Right but i'm not sure what the issue is. Capital S is wrong. The actual pathing is lowercase on github. Tools like glide that validate that the remote matches the import break on updates.

@harnash
Copy link

harnash commented Apr 13, 2017

It may be wrong but changing it now disrupts builds too especially when you are pulling some libraries you have no control over. See first lines in README:

Seeing weird case-sensitive problems? See this issue. This change has been reverted. I apologize for causing this. I greatly underestimated the impact this would have. Logrus strives for stability and backwards compatibility and failed to provide that.

Well it seems I need to change it back in our codebase. I think you may close this issue since it is a duplicate.

@sirupsen
Copy link
Owner

sirupsen commented May 15, 2017

Glide will work if you change to use lower-case, and this repo supports both upper-case (for backwards compatibility) and lower-case. The README has been updated to use lower-case and has a note on this.

@sirupsen sirupsen closed this May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants