Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absorb @siren-js/core #11

Closed
dillonredding opened this issue Jan 8, 2023 · 0 comments · Fixed by #13
Closed

Absorb @siren-js/core #11

dillonredding opened this issue Jan 8, 2023 · 0 comments · Fixed by #13
Assignees
@dillonredding
Labels
enhancement New feature or request

Comments

@dillonredding
Copy link
Member

In an attempt to separate client and server concerns, this library should absorb (and simplify) the parse/validate logic of @siren-js/core since a server should not need to perform those operations, and if they do, that likely means the server also acts as a client and should therefore use is library. From there we can write a library better tailored to Siren servers and deprecate @siren-js/core.
@dillonredding dillonredding self-assigned this Jan 9, 2023
@dillonredding dillonredding added the enhancement New feature or request label Jan 12, 2023
@dillonredding dillonredding mentioned this issue Jan 29, 2023
Merged
@dillonredding dillonredding linked a pull request Jan 29, 2023 that will close this issue
v0.6.0: Top-Level Functions, Serialization Simplification, and Client Models #13
Merged
dillonredding added a commit that referenced this issue Mar 7, 2023
@dillonredding
v0.6.0: Top-Level Functions, Serialization Simplification, and Client…
93dcb05 
… Models (#13)

Remove `SirenClient` class in favor of top-level functions (see below).

Remove support for Node.js.

Add `follow`, `submit`, and `parse` functions.

Add TypeDoc for automated doc generation.

Absorb Siren element classes from `@siren-js/core`.

Simplify default serializer.

Resolves: #11, #12, #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dillonredding dillonredding

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.6.0: Top-Level Functions, Serialization Simplification, and Client Models siren-js/client
1 participant
@dillonredding