Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Analytics #1930

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Add Google Analytics #1930

merged 1 commit into from
Oct 14, 2018

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Oct 13, 2018

Add analytics to our site to analyze search traffic patterns.

Right now we are a little bit in the dark with regards to how people come to our site, but we do know they sometimes end up at the wrong docs.
Having analytics would enable us to make better decisions for how to improve our docs and also verify that our changes work as intended

Ref #1927 and #1929

With increasing number of infrastructure points and logons we might need some central password store for the Sinon members, like 1Password.
Right now, I added this to my personal google account, as a start. I am not too intimately aware of Google Search Console, but
I am quite certain I can just add the rest of the team as well.

No verification for us - it's a file for Google to verify :-)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.84%

Totals Coverage Status
Change from base Build 2712: 0.0%
Covered Lines: 2059
Relevant Lines: 2131

💛 - Coveralls

@fatso83 fatso83 merged commit 2aa4458 into sinonjs:master Oct 14, 2018
@fatso83 fatso83 deleted the google-search-console branch October 14, 2018 10:12
@mroderick
Copy link
Member

Ew. I guess it's necessary, but I am still not a fan of giving more data to Google.

@fatso83
Copy link
Contributor Author

fatso83 commented Oct 17, 2018

We could use any other tracker. I don't care that much which.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants