Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle catalog flag as well as properties flag #55

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Handle catalog flag as well as properties flag #55

merged 1 commit into from
Apr 17, 2019

Conversation

robmoore
Copy link
Contributor

Addresses #54

@cmerrick
Copy link

Hi @robmoore, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@robmoore
Copy link
Contributor Author

I can also add to the error message on line 698 so that it reads "No properties or catalog were selected", if desired.

@luandy64
Copy link
Contributor

@robmoore If you can sign the contribution license agreement, I'll work on reviewing this

@cmerrick
Copy link

You did it @robmoore!

Thank you for signing the Singer Contribution License Agreement.

@luandy64 luandy64 merged commit c23632e into singer-io:master Apr 17, 2019
@luandy64
Copy link
Contributor

Thanks @robmoore! 👍

@robmoore
Copy link
Contributor Author

Not sure what your release schedule is but I was hoping to be able to use this change via Pypi. Any ideas on when that might happen?

@luandy64
Copy link
Contributor

It should be out now, sorry about that.

@robmoore
Copy link
Contributor Author

No worries! Just wanted to know what to expect. Thanks for the quick turnaround.

@fx fx mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants