Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed parent id parameter to a function for different streams #32

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

leslievandemark
Copy link
Contributor

Description of change

Fix for #29 which caused an error in certain child streams. This pr only modifies the behavior of Visits stream

Manual QA steps

Risks

Rollback steps

  • revert this branch

@leslievandemark leslievandemark merged commit 85fc3ad into master Jun 15, 2021
@leslievandemark leslievandemark deleted the childstream-fix branch June 15, 2021 16:21
leslievandemark added a commit that referenced this pull request Jun 15, 2021
leslievandemark added a commit that referenced this pull request Jun 15, 2021
* Revert "Call join correctly (#34)"

This reverts commit 76f8b3c.

* Revert "changed parent id parameter to a function for different streams (#32)"

This reverts commit 85fc3ad.

* Revert "copy of pr#15 with merge conflicts resolved  (#29)"

This reverts commit 06828fa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants