-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BigInt support and Unicode handling #9
Conversation
@broofa Really sorry for leaving this for so long. Real-life and a way too long PR queue came in the way... |
I just tested with latest version of AVA and
XO and ESLint support it now. Can you bring back XO? |
You need to update index.d.ts too. |
@sindresorhus Updated to use
|
Thank you for your work on this, @broofa 👍 |
mocha
andava
both puke if you try to do BigInts in them, so I've had to resort to testing with the nativeassert
module. That may or may not be adequate for you. Andxo
doesn't recognize bigint literals, nor does ESLint, so I've had to remove the linting step fromnpm test
.Note: I ended up incorporating some of @ShynRou's work for BigInt support. He should get the IssueHunt bounty for this.
P.S. FWIW, the legacy implementation (32 bit Numbers) is ~9X faster than the BigInt counterpart. https://jsperf.com/fnv1a-number-vs-bigint-perf
Fixes #2
Fixes #3
Closes #7
Closes #4