Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more specific CSS selector for Search results Close button #2063

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

mquevill
Copy link
Collaborator

The previous selector (.x14hiurz) was not specific enough for the search results "Close" button, since it also affected preferences selectors below.

image
image

The color is updated so the "Close" actually looks like a clickable button and no longer affects the preferences checkboxes.

image
image

(I think I'd like more contrast on the checkboxes from a design perspective, but am reverting to default styles for now.)

@dusansimic
Copy link
Collaborator

I think I'd like more contrast on the checkboxes from a design perspective, but am reverting to default styles for now.

I completely agree, but that could be in an another pr. Thanks for this!

@dusansimic dusansimic merged commit e9fe587 into sindresorhus:main Sep 14, 2023
@mquevill mquevill deleted the SearchCloseButton branch September 21, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants