Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray icon/indicator Fix #2041

Merged
merged 6 commits into from
Sep 2, 2023
Merged

Tray icon/indicator Fix #2041

merged 6 commits into from
Sep 2, 2023

Conversation

stkrknds
Copy link
Contributor

@stkrknds stkrknds commented Jul 28, 2023

Hello this is a fix for the tray icon/indicator issue. After running the tests, I got an error about putting await inside of a loop. So unfortunately, I had to change the selector of the sidebar and remove the loop.

Partially fixes #1825 (this wouldn't implement notifications).

Fixes #1995
Fixes #1823
Fixes #2031

@dusansimic
Copy link
Collaborator

Thanks @stkrknds for the contribution! I've suggested some changes so once they're implemented, we can merge this.

stkrknds and others added 4 commits August 23, 2023 14:43
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
@stkrknds
Copy link
Contributor Author

I have made some changes, so that only the left sidebar is observed for the chats icon. I think that's the best that can be done in terms of efficiency. The only downside is that there is now an additional selector(for the left sidebar) which may break in the future.

@stkrknds stkrknds requested a review from dusansimic August 24, 2023 11:35
@dusansimic
Copy link
Collaborator

The only downside is that there is now an additional selector(for the left sidebar) which may break in the future.

That is true, but I think it's better to have a new selector that can be fixed than having one more mutation observer that checks a lot of elements on the page for changes. That would consume more resources and in turn make Caprine slower and more resource hungry which is already an issue. I think the path forward is either optimizing existing observer or removing them altogether.

@dusansimic dusansimic merged commit 0d38a71 into sindresorhus:main Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants