-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tray icon/indicator Fix #2041
Tray icon/indicator Fix #2041
Conversation
Thanks @stkrknds for the contribution! I've suggested some changes so once they're implemented, we can merge this. |
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
I have made some changes, so that only the left sidebar is observed for the chats icon. I think that's the best that can be done in terms of efficiency. The only downside is that there is now an additional selector(for the left sidebar) which may break in the future. |
That is true, but I think it's better to have a new selector that can be fixed than having one more mutation observer that checks a lot of elements on the page for changes. That would consume more resources and in turn make Caprine slower and more resource hungry which is already an issue. I think the path forward is either optimizing existing observer or removing them altogether. |
Hello this is a fix for the tray icon/indicator issue. After running the tests, I got an error about putting await inside of a loop. So unfortunately, I had to change the selector of the sidebar and remove the loop.
Partially fixes #1825 (this wouldn't implement notifications).
Fixes #1995
Fixes #1823
Fixes #2031