Check if stored_data is not empty before parsing it to json

[JanStevens]

In light of issue #406

[bf4]

Is it possible that the bug is actually that stored_data should be nil not '' or "null" and that is a bug originated in how stored_data is generated? That said, the fix could also be if stored_data && !stored_data.empty?

[JanStevens]

This largely depends on your JSON implementation, It seems that Oj for example returns nil in case stored_data is nil. Standaard JSON lib will raise a TypeError

I agree that the fix could also be to check if stored_data is not empty (which would make sense)

Regards

[bf4]

Would you mind rebasing your commits and adding a test for this?

[JanStevens]

Looking at the test suite and current solutions I would say its already being tested:

• https://github.com/colszowka/simplecov/blob/master/spec%2Fmerge_helpers_spec.rb?ts=2#L48-L58

I can add specific test to see that we always return an empty hash incase the file couldn't be read but the be_empty seems to be sufficient.

[JanStevens]

Lets merge merge merge? xD

[xaviershay]

If it was already being tested, then why weren't those tests failing?

[xaviershay]

I'm not convinced this addresses the issue. If stored_data was empty the existing code still works (as per the specs you linked, and also by inspection - it will just iterate over an empty hash.) See comments on #406. Closing until someone convinces me otherwise.