Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector in editor component test #3067

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Fix selector in editor component test #3067

merged 1 commit into from
Mar 7, 2025

Conversation

kylebuss
Copy link
Collaborator

@kylebuss kylebuss commented Mar 7, 2025

This addresses the querySelector made for querying the source quill editor placeholder text.


This change is Reviewable

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (bc7335d) to head (5c9d332).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3067   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         563      563           
  Lines       32667    32667           
  Branches     5306     5306           
=======================================
  Hits        27019    27019           
- Misses       4856     4868   +12     
+ Partials      792      780   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kylebuss)

@Nateowami Nateowami enabled auto-merge (squash) March 7, 2025 19:04
@Nateowami Nateowami merged commit e58a5a2 into master Mar 7, 2025
16 checks passed
@Nateowami Nateowami deleted the fix/bad-selector branch March 7, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants