Fix walk of target delegations to be DFS (#95)

sigstore · Aug 24, 2024 · fc326d4 · fc326d4
1 parent facfd4f
commit fc326d4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -135,7 +135,7 @@ jobs:
         run: touch requirements.txt
 
       - name: Run the TUF conformance tests
-        uses: theupdateframework/tuf-conformance@67f38b6718a25642fb489419260d0eddcef95a7a
+        uses: theupdateframework/tuf-conformance@2c8a0a73f2eea756ddc2e8b11077cb063aa221ed
         with:
           entrypoint: ${{ github.workspace }}/bin/tuf-conformance-entrypoint
           artifact-name: "test repositories ${{ matrix.ruby }} ${{ matrix.os }}"

diff --git a/lib/sigstore/tuf/updater.rb b/lib/sigstore/tuf/updater.rb
@@ -222,7 +222,7 @@ def preorder_depth_first_walk(target_path)
       visited_role_names = Set.new
 
       while delegations_to_visit.any? && visited_role_names.size < @config.max_delegations
-        role_name, parent_role = delegations_to_visit.shift
+        role_name, parent_role = delegations_to_visit.pop
         next if visited_role_names.include?(role_name)
 
         targets = load_targets(role_name, parent_role)