Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign Bundle with a Timestamp Authority #1216
Sign Bundle with a Timestamp Authority #1216
Changes from all commits
c7de7db
ac0fa7e
cc16b31
9a1bbf4
f686f53
86e4885
8d95387
9f9adf8
303210f
7733a9b
dc6545c
e0c10e5
e0e5f6d
b28a849
1684b74
b4744dd
e18f80f
ad1d6f1
3f7146b
f2c2124
9de30ed
dae1fc2
4272a5b
5c4dc68
c5abd36
fcc890a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love that we pull down a binary here, and hardcode the version. It'd be great if we could get this into Dependabot somehow.
(Not a blocker, flagging as a follow-up.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging: it's not ideal that this parameter list continues to grow; I think we could probably slice it down substantially by passing the entire
ClientTrustConfig
and doing the instantiations internally.That'd be good for a follow-on refactor PR here.