Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand examples documentation #412

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Feb 18, 2025

Summary

PR expands the documentation for the examples. The order of go build commands in the Makefile for the build-examples target is changes to correspond to the alphabetical sorted order.

Release Note

NONE

Documentation

examples/README.md is updated and expanded, no other documentation changes are necessary.

@dmitris dmitris requested a review from a team as a code owner February 18, 2025 16:22
@dmitris dmitris force-pushed the examples-build-usage branch from 5c02bd2 to 298e8fc Compare February 18, 2025 16:22
@dmitris dmitris force-pushed the examples-build-usage branch from 298e8fc to f9d4eed Compare February 18, 2025 16:25
Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me - a few minor comments / suggestions.

Signed-off-by: Dmitry Savintsev <dsavints@gmail.com>
@dmitris dmitris force-pushed the examples-build-usage branch from f9d4eed to e1cf27b Compare February 20, 2025 08:28
@dmitris
Copy link
Contributor Author

dmitris commented Feb 20, 2025

thanks @steiza - addressed your feedback

Signed-off-by: Dmitry Savintsev <dsavints@gmail.com>
@dmitris dmitris force-pushed the examples-build-usage branch from e1cf27b to 53ba2c0 Compare February 20, 2025 08:32
Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@steiza steiza merged commit 71da7c0 into sigstore:main Feb 20, 2025
11 checks passed
@dmitris dmitris deleted the examples-build-usage branch February 20, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants