Skip to content

Commit

Permalink
Delete Kiln and Ropsten configs (#4038)
Browse files Browse the repository at this point in the history
## Proposed Changes

Remove built-in support for Ropsten and Kiln via the `--network` flag. Both testnets are long dead and deprecated.

This shaves about 30MiB off the binary size, from 135MiB to 103MiB (maxperf), or 165MiB to 135MiB (release).
  • Loading branch information
michaelsproul committed Mar 1, 2023
1 parent 047c754 commit ca1ce38
Show file tree
Hide file tree
Showing 11 changed files with 7 additions and 176 deletions.
2 changes: 1 addition & 1 deletion book/src/database-migrations.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ Several conditions need to be met in order to run `lighthouse db`:
2. The command must run as the user that owns the beacon node database. If you are using systemd then
your beacon node might run as a user called `lighthousebeacon`.
3. The `--datadir` flag must be set to the location of the Lighthouse data directory.
4. The `--network` flag must be set to the correct network, e.g. `mainnet`, `prater` or `ropsten`.
4. The `--network` flag must be set to the correct network, e.g. `mainnet`, `prater` or `sepolia`.

The general form for a `lighthouse db` command is:

Expand Down
20 changes: 0 additions & 20 deletions common/eth2_config/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -278,26 +278,6 @@ define_hardcoded_nets!(
// directory.
GENESIS_STATE_IS_KNOWN
),
(
// Network name (must be unique among all networks).
kiln,
// The name of the directory in the `eth2_network_config/built_in_network_configs`
// directory where the configuration files are located for this network.
"kiln",
// Set to `true` if the genesis state can be found in the `built_in_network_configs`
// directory.
GENESIS_STATE_IS_KNOWN
),
(
// Network name (must be unique among all networks).
ropsten,
// The name of the directory in the `eth2_network_config/built_in_network_configs`
// directory where the configuration files are located for this network.
"ropsten",
// Set to `true` if the genesis state can be found in the `built_in_network_configs`
// directory.
GENESIS_STATE_IS_KNOWN
),
(
// Network name (must be unique among all networks).
sepolia,
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Binary file not shown.

This file was deleted.

This file was deleted.

This file was deleted.

Binary file not shown.
12 changes: 6 additions & 6 deletions testing/web3signer_tests/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -660,17 +660,17 @@ mod tests {
}

#[tokio::test]
async fn ropsten_base_types() {
test_base_types("ropsten", 4250).await
async fn sepolia_base_types() {
test_base_types("sepolia", 4250).await
}

#[tokio::test]
async fn ropsten_altair_types() {
test_altair_types("ropsten", 4251).await
async fn sepolia_altair_types() {
test_altair_types("sepolia", 4251).await
}

#[tokio::test]
async fn ropsten_merge_types() {
test_merge_types("ropsten", 4252).await
async fn sepolia_merge_types() {
test_merge_types("sepolia", 4252).await
}
}

0 comments on commit ca1ce38

Please sign in to comment.