Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop spreading as prop onto root element #87

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

hasparus
Copy link
Contributor

Previously, the as prop was spread onto the component it defines, so we get:

<p as="p">
<span as="span">
image

I destructured it to keep the resulting DOM clean.

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-wrap-balancer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 9:46pm

@pacocoursey pacocoursey merged commit 7bd6981 into shuding:main Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants